# Fix inconsistancy in "max" value definition of a distribution range

## Description

Highlighted in a discussion in this commit: https://gem5-review.googlesource.com/c/public/gem5/+/39297

There is inconsistent definition of what the maximum value of a range is. The code/comments in `storage.hh` largely suggests max being the maximum value of the range, not inclusive: i.e.: `[min,max[`, though this is not the case in line with "Bucket size (%f) does not divide range [%f:%f] into equal-sized buckets" error check. There is evidence that distribution constructions elsewhere in the code base are assuming [min,max] or some alternative: https://gem5-review.googlesource.com/c/public/gem5/+/41413

For this bug to be fixed the codebase must be searched and instances of distribution construction and each checked that "max" values are conform to the `[min,max[` definition in storage.hh. Then the "Bucket size" error check must be altered accordingly.

None

Unassigned

Bobby Bruce

Medium